fix(react): Set handled value in ErrorBoundary depending on fallback
#10989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
This makes 100% sense. |
lforst
approved these changes
Mar 8, 2024
Closed
Lms24
added a commit
that referenced
this pull request
Mar 12, 2024
#10989) Previously, we made a change to always mark such errors as unhandled (#8914). However, as pointed out and discussed in #10985, this isn't always the best default value. I propose we set handled/unhandled depending on the presence of the `fallback` component. If users specify a fallback, I think it's safe to mark the error handled, given that users show something else instead of the errored component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts when we mark errors caught in our React SDK's
ErrorBoundaryas handled/unhandled.Previously, we made a change to always mark such errors as unhandled (#8914). However, as pointed out and discussed in #10985, this isn't always the best default value. I propose we set handled/unhandled depending on the presence of the
fallbackcomponent. If users specify a fallback, I think it's safe to mark the error handled, given that users show something else instead of the errored component.Would appreciate thoughts from our React experts ;)
closes #10985