Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update biome to v1.5.2 #10102

Merged
merged 3 commits into from
Dec 12, 2024
Merged

build: update biome to v1.5.2 #10102

merged 3 commits into from
Dec 12, 2024

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Jan 8, 2024 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.27 KB - -
@sentry/browser - with treeshaking flags 21.94 KB - -
@sentry/browser (incl. Tracing) 35.77 KB - -
@sentry/browser (incl. Tracing, Replay) 73 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.4 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.31 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.8 KB - -
@sentry/browser (incl. Feedback) 40.02 KB - -
@sentry/browser (incl. sendFeedback) 27.88 KB - -
@sentry/browser (incl. FeedbackAsync) 32.67 KB - -
@sentry/react 25.94 KB - -
@sentry/react (incl. Tracing) 38.59 KB - -
@sentry/vue 27.47 KB - -
@sentry/vue (incl. Tracing) 37.61 KB - -
@sentry/svelte 23.43 KB - -
CDN Bundle 24.41 KB - -
CDN Bundle (incl. Tracing) 37.43 KB - -
CDN Bundle (incl. Tracing, Replay) 72.62 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.98 KB - -
CDN Bundle - uncompressed 71.69 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.99 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.06 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.28 KB - -
@sentry/nextjs (client) 38.88 KB - -
@sentry/sveltekit (client) 36.27 KB - -
@sentry/node 162.4 KB - -
@sentry/node - without tracing 98.57 KB -0.01% -1 B 🔽
@sentry/aws-serverless 126.27 KB -0.01% -2 B 🔽

View base workflow run

@anonrig anonrig mentioned this pull request Jan 8, 2024
Closed
1 task
@anonrig anonrig force-pushed the update-biome-v1-5-0 branch from 38b8eb9 to fb1dbbc Compare January 10, 2024 14:40
@anonrig anonrig changed the title build: update biome to v1.5.0 build: update biome to v1.5.1 Jan 10, 2024
@ematipico
Copy link

ematipico commented Jan 11, 2024 •
edited
Loading

I tested it with my local - fixed - version, and there are now 33 errors. All of them are formatting fixes :)

@anonrig anonrig changed the title build: update biome to v1.5.1 build: update biome to v1.5.2 Jan 16, 2024
@anonrig anonrig force-pushed the update-biome-v1-5-0 branch from fb1dbbc to 2ed2e97 Compare January 16, 2024 14:24
@anonrig anonrig requested review from a team, Lms24 and ale-cota and removed request for a team January 16, 2024 14:27
Lms24
Lms24 reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a question about the Json config.

@anonrig anonrig force-pushed the update-biome-v1-5-0 branch from 2ed2e97 to 474548e Compare January 16, 2024 15:06
Lms24
Lms24 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for explaining, let's update!

Also seriously hoping this update fixes the auto formatting bug when adding brackets in JSDoc comments.

@anonrig
Copy link
Contributor Author

anonrig commented Jan 16, 2024

Thx for explaining, let's update!

Also seriously hoping this update fixes the auto formatting bug when adding brackets in JSDoc comments.

I think that's Eslint not Biome?

@anonrig anonrig force-pushed the update-biome-v1-5-0 branch from 474548e to 9b1e358 Compare January 16, 2024 16:33
@andreiborza andreiborza requested a review from a team as a code owner December 12, 2024 09:30
@andreiborza andreiborza merged commit 13bb652 into develop Dec 12, 2024
158 checks passed
@andreiborza andreiborza deleted the update-biome-v1-5-0 branch December 12, 2024 10:20
@HazAT HazAT mentioned this pull request Dec 12, 2024
Merged
mydea pushed a commit that referenced this pull request Dec 12, 2024
@HazAT @andreiborza
chore: Add external contributor to CHANGELOG.md (#14677)
938fe65 
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #10102

Co-authored-by: andreiborza <168741329+andreiborza@users.noreply.github.com>
@anonrig
Copy link
Contributor Author

anonrig commented Dec 12, 2024

🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@ale-cota ale-cota Awaiting requested review from ale-cota ale-cota was automatically assigned from getsentry/team-web-sdk-frontend

@mydea mydea Awaiting requested review from mydea

@chargome chargome Awaiting requested review from chargome

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anonrig @ematipico @Lms24 @andreiborza