Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user/userContext to list of properties merged into _globalContext via RavenConfig #741

Closed
simenbrekken opened this issue Oct 17, 2016 · 1 comment
Closed

Add user/userContext to list of properties merged into _globalContext via RavenConfig #741

simenbrekken opened this issue Oct 17, 2016 · 1 comment

Comments

@simenbrekken
Copy link

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

Raven only handles tags and extra when reading RavenConfig. This makes it impossible to run Raven.setUser when raven is being loaded and configured asynchronously via RavenConfig.

What is the desired behavior?

Include user/userContext in the list of properties that are merged into the _globalContext

This will allow integrations where RavenConfig is used to per-configure raven-js before Raven is loaded to include information about the current user.
@benvinegar
Copy link
Contributor

I encountered this issue personally, and it was pretty confusing. Going to add this for 3.9.0.

benvinegar added a commit that referenced this issue Nov 11, 2016
@benvinegar
Can set user context via config (fixes #741)
55df3e0
denstepa pushed a commit to denstepa/raven-js that referenced this issue Jan 5, 2017
@benvinegar @denstepa
Can set user context via config (fixes getsentry#741) (getsentry#762)
2d99fb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benvinegar @simenbrekken