Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document/Confirm Support for Web Workers #429

Closed
dcramer opened this issue Nov 23, 2015 · 4 comments
Closed

Document/Confirm Support for Web Workers #429

dcramer opened this issue Nov 23, 2015 · 4 comments

Comments

@dcramer
Copy link
Member

dcramer commented Nov 23, 2015

Came up today in IRC. Pretty sure they work with XHR, but it'd be nice to know concretely.

@varenc
Copy link

varenc commented Mar 9, 2017

yo @dcramer, I'd love some concreteness on this! Couldn't find it in the docs but some recent commits make me think this is being explicitly supported now?

@LewisJEllis
Copy link
Contributor

LewisJEllis commented Mar 9, 2017

@varenc we do support/work in webworkers now, as of #792. #855 was also related.

I'll make sure to add a mention of this to the docs before I close this issue.

@varenc
Copy link

varenc commented Mar 9, 2017

thanks for the info! I wasn't sure... the docs here say that window.json needs to be defined for ravenjs which it isn't in a web worker. Should I also import something like json2.js to make it work? some testing show it's working despite this though I fear I'm not testing thoroughly enough.

@LewisJEllis
Copy link
Contributor

That really just means to say "we need a JSON global variable", which webworkers do have; describing it as window.JSON is perhaps overly specific. Anything modern enough to have webworkers is modern enough to have JSON, so you should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants