Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo for log4j2 async appenders #4136

Closed

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Feb 4, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer closed this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Demo for log4j2 async appenders ([#4136](https://github.com/getsentry/sentry-java/pull/4136))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d14211b

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 404.96 ms 470.78 ms 65.82 ms
Size 1.65 MiB 2.31 MiB 678.16 KiB

Baseline results on branch: feat/otel-server-request-headers

Startup times

Revision Plain With Sentry Diff
f4ffaaa 395.13 ms 479.50 ms 84.37 ms
461c657 405.82 ms 430.92 ms 25.10 ms
01d4a6e 408.89 ms 451.35 ms 42.45 ms

App size

Revision Plain With Sentry Diff
f4ffaaa 1.65 MiB 2.31 MiB 678.16 KiB
461c657 1.65 MiB 2.31 MiB 677.61 KiB
01d4a6e 1.65 MiB 2.31 MiB 677.61 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant