Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-apply 7.x.x changes #4124

Merged
merged 9 commits into from
Jan 30, 2025
Merged

Re-apply 7.x.x changes #4124

merged 9 commits into from
Jan 30, 2025

Conversation

markushi
Copy link
Member

@markushi markushi commented Jan 28, 2025 •
edited
Loading

💡 Motivation and Context

Re-applies all relevant changes since the 7.20.0 release, except some NDK changes which I'll follow up with later.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

🔮 Next steps

romtsn and others added 5 commits January 28, 2025 13:39
@romtsn @markushi
Various fixes to instrumentations running on the main thread (#4051)
7770dd7 
* Get rid of redundant requireNonNull

* Do not instrument Window.Callback multiple times

* Do not instrument FileIO if tracing is disabled

* Do not traverse children if a touch event is not within view groups bounds

* Add test for SentryFileOutputStream

* Fix test

* Fix test

* Changelog

* pr id

* Fix api dump
@romtsn @getsentry-bot
@stefanosiano @markushi
Fix BroadcastReceivers (#4052)
d1d1bd8 
* Drop TempSesnorBreadcrumbIntegration

* Drop PhoneStateBreadcrumbsIntegration

* Reduce number of system events we're listening to and use RECEIVER_NOT_EXPORTED

* Format code

* Changelog

* Update CHANGELOG.md

Co-authored-by: Stefano <stefano.siano@sentry.io>

* Update CHANGELOG.md

Co-authored-by: Stefano <stefano.siano@sentry.io>

---------

Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Co-authored-by: Stefano <stefano.siano@sentry.io>
@markushi
Only provide {{auto}} ip-address if sendDefaultPii is enabled
ada5f4c
@markushi
Update changelog
2fcc388
@romtsn @markushi @stefanosiano
Reduce the number of IPC calls (#4058)
1335a5c 
* Remove binder call for external storage

* Remove binder call for memory in profiler

* Cache static values to avoid binder calls

* Comment

* Changelog

* Formatting

* Fix tests

* Minor fixes

* change protected method in final class to private

---------

Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
Co-authored-by: stefanosiano <stefano.siano@sentry.io>
@github-actions GitHub Actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 463.55 ms 543.18 ms 79.63 ms
Size 1.65 MiB 2.31 MiB 678.88 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: markushi/re-apply-7.x.x-changes

Startup times

Revision Plain With Sentry Diff
d80a7c3 397.55 ms 426.59 ms 29.04 ms
7e764ee 527.49 ms 640.92 ms 113.43 ms

App size

Revision Plain With Sentry Diff
d80a7c3 1.65 MiB 2.31 MiB 677.15 KiB
7e764ee 1.65 MiB 2.31 MiB 677.06 KiB

romtsn
romtsn reviewed Jan 28, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

@github-actions GitHub Actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

@markushi markushi enabled auto-merge (squash) January 30, 2025 15:15
@github-actions GitHub Actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

@markushi markushi merged commit 2748875 into main Jan 30, 2025
36 of 37 checks passed
@markushi markushi deleted the markushi/re-apply-7.x.x-changes branch January 30, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markushi @romtsn