feat(android-ndk): add api for getting debug images by addresses #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cc @markushi can you have a quick look pls |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b05e00c | 408.52 ms | 443.22 ms | 34.70 ms |
| 77ae45a | 410.94 ms | 491.28 ms | 80.35 ms |
| ce9de6a | 428.98 ms | 502.62 ms | 73.64 ms |
| 86c73f9 | 402.86 ms | 441.96 ms | 39.10 ms |
| a40047a | 339.33 ms | 467.08 ms | 127.76 ms |
| 9b805f5 | 460.37 ms | 526.70 ms | 66.33 ms |
| e0c74e1 | 438.56 ms | 551.48 ms | 112.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b05e00c | 1.58 MiB | 2.21 MiB | 640.27 KiB |
| 77ae45a | 1.58 MiB | 2.21 MiB | 638.68 KiB |
| ce9de6a | 1.65 MiB | 2.31 MiB | 678.86 KiB |
| 86c73f9 | 1.65 MiB | 2.31 MiB | 678.17 KiB |
| a40047a | 1.65 MiB | 2.31 MiB | 678.86 KiB |
| 9b805f5 | 1.58 MiB | 2.21 MiB | 640.27 KiB |
| e0c74e1 | 1.58 MiB | 2.21 MiB | 640.27 KiB |
markushi
reviewed
Feb 4, 2025
sentry-android-ndk/src/main/java/io/sentry/android/ndk/DebugImagesLoader.java
Outdated
Show resolved
Hide resolved
update test clean up update test update comments remove file fix imports update docs revert doc use hashset Format code update naming apiDump Improve Nullability, consider case of null imageSize Update tests, ensure code_file and debug_file are set
|
tested it on Flutter and looks good 👍 |
markushi
approved these changes
Feb 11, 2025
romtsn
approved these changes
Feb 11, 2025
stefanosiano
approved these changes
Feb 11, 2025
markushi
added a commit
that referenced
this pull request
Feb 11, 2025
--------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
markushi
added a commit
that referenced
this pull request
Feb 11, 2025
* feat(android-ndk): add api for getting debug images by addresses (#4089) --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> * Update Changelog * Format code * Fix switch sync/data classes to match 7.x.x --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
question: can I push this change onto a v7 branch? We cannot bump to Android v8 at this moment because we also depend on min android api 19 which has been bumped to 21 here. if not possible we'll mark this as a Flutter v9 feature
📜 Description
Adds debug images loader API for getting images by addresses
💡 Motivation and Context
On Flutter we are currently loading all available debug images which can sometimes range up to 300 images but in most cases only 1 is actually used so this is much more efficient and the envelope is therefore smaller
Closes #3925
💚 How did you test it?
Unit test, e2e test with Flutter app
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps