-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ignored check performance #3992
Conversation
|
Performance metrics 🚀
|
# Conflicts: # sentry/src/main/java/io/sentry/util/SpanUtils.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM already. Can you please add your performance comparison results?
import kotlin.test.assertFalse | ||
import kotlin.test.assertTrue | ||
|
||
class SpanUtilsTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test asking for the same origin again, so we can also test the cache?
Co-authored-by: Alexander Dinauer <adinauer@users.noreply.github.com>
# Conflicts: # CHANGELOG.md # sentry/api/sentry.api
jmh benchmarks run on Java 17 (17.0.4.1 Temurin):Benchmarks comparing the changes with our current implementation: Each implementation is given a list of 10 identical origins to be ignored. Comparison when no origin matchesAll 10 items in the list need to be checked.
Comparison String equalsThe 6th entry in the list matches using
Comparison regex matchThe 7th entry in the list matches using regex pattern.
|
📜 Description
Improves performance of checking whether certain SpanOrigins, TransactionNames or Checkins should be ignored.
💡 Motivation and Context
Fixes #3967
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps