Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle, AGP and Kotlin versions #3936

Merged
merged 19 commits into from
Feb 5, 2025
Merged

Conversation

markushi
Copy link
Member

@markushi markushi commented Nov 28, 2024

📜 Description

Supersedes #3839

💡 Motivation and Context

New features, faster builds.

Closes #3784

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.33 ms 440.50 ms 49.17 ms
Size 1.58 MiB 2.21 MiB 638.68 KiB

Previous results on branch: chore/bump-gradle-agp-kotlin-8.x.x

Startup times

Revision Plain With Sentry Diff
28de1fc 399.50 ms 410.55 ms 11.05 ms
34068df 340.50 ms 374.73 ms 34.23 ms
b394bce 397.31 ms 444.14 ms 46.83 ms
2cfebea 419.29 ms 496.17 ms 76.88 ms
6c7af4b 411.45 ms 446.60 ms 35.16 ms

App size

Revision Plain With Sentry Diff
28de1fc 1.58 MiB 2.21 MiB 638.69 KiB
34068df 1.58 MiB 2.21 MiB 638.78 KiB
b394bce 1.58 MiB 2.21 MiB 638.69 KiB
2cfebea 1.58 MiB 2.21 MiB 638.68 KiB
6c7af4b 1.58 MiB 2.21 MiB 638.68 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also check the comments from #3839 around uppercase/lowercase and that weird extension function?

Base automatically changed from 8.x.x to main January 9, 2025 15:47
@romtsn romtsn requested a review from lcian as a code owner February 4, 2025 11:26
@romtsn romtsn merged commit 36a7532 into main Feb 5, 2025
34 of 36 checks passed
@romtsn romtsn deleted the chore/bump-gradle-agp-kotlin-8.x.x branch February 5, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sources & JavaDoc variants are missing in Gradle's metadata
2 participants