Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 50 - Auto config for Spring Boot combined with OTel but without agent #3846

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Nov 5, 2024

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 50 - Auto config for Spring Boot combined with OTel but without agent ([#3846](https://github.com/getsentry/sentry-java/pull/3846))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 30c5ebd

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 384.00 ms 460.10 ms 76.10 ms
Size 1.65 MiB 2.31 MiB 672.57 KiB

Previous results on branch: feat/spring-boot-autoconfig-for-otel-no-agent

Startup times

Revision Plain With Sentry Diff
fe6463f 408.02 ms 421.84 ms 13.82 ms
28031d4 402.63 ms 443.26 ms 40.63 ms

App size

Revision Plain With Sentry Diff
fe6463f 1.70 MiB 2.36 MiB 670.64 KiB
28031d4 1.65 MiB 2.31 MiB 672.60 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments about code that could be re-enabled/duplicate depenencies

@adinauer adinauer marked this pull request as ready for review November 11, 2024 14:52
@adinauer adinauer merged commit ab7e6fd into 8.x.x Nov 11, 2024
22 of 26 checks passed
@adinauer adinauer deleted the feat/spring-boot-autoconfig-for-otel-no-agent branch November 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants