Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityLifecycleIntegration now sets cold or warm start type if not โ€ฆ #3832

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

stefanosiano
Copy link
Member

๐Ÿ“œ Description

ActivityLifecycleIntegration now sets cold or warm start type if not set even in perfV2
updated test for perfV2 enabled by default

#skip-changelog

๐Ÿ’ก Motivation and Context

Fix tests

๐Ÿ’š How did you test it?

๐Ÿ“ Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

๐Ÿ”ฎ Next steps

โ€ฆset even in perfV2

updated test for perfV2 enabled by default
@stefanosiano stefanosiano marked this pull request as ready for review October 28, 2024 15:37
Copy link
Contributor

Performance metrics ๐Ÿš€

ย  Plain With Sentry Diff
Startup time 477.89 ms 499.06 ms 21.17 ms
Size 1.70 MiB 2.36 MiB 671.42 KiB

@adinauer adinauer merged commit 57b2da5 into 8.x.x Oct 29, 2024
21 of 23 checks passed
@adinauer adinauer deleted the fix/v8-tests-perfv2 branch October 29, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants