-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close Scopes
before replacing options on global Scope
#3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d sentry-graphql-core
…ryInstrumentation bean if missing
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e12b4d2 | 456.29 ms | 543.46 ms | 87.17 ms |
a121565 | 474.11 ms | 543.36 ms | 69.25 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e12b4d2 | 1.70 MiB | 2.35 MiB | 669.05 KiB |
a121565 | 1.70 MiB | 2.35 MiB | 669.05 KiB |
stefanosiano
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
lbloder
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
An error occurred while trying to automatically change base from
feat/spring-support-graphql-v22
to
8.x.x
October 7, 2024 13:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Change order of replacing options on global scope and closing previous
Scopes
.💡 Motivation and Context
When re-initializing the SDK, it called
close
on integrations, profiler etc. that are supposed to be used after the second call toSentry.init
instead of the ones from first call to init.💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps