Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Scopes before replacing options on global Scope #3750

Merged
merged 11 commits into from
Oct 9, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Oct 3, 2024

📜 Description

Change order of replacing options on global scope and closing previous Scopes.

💡 Motivation and Context

When re-initializing the SDK, it called close on integrations, profiler etc. that are supposed to be used after the second call to Sentry.init instead of the ones from first call to init.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 437.57 ms 495.88 ms 58.31 ms
Size 1.70 MiB 2.35 MiB 669.05 KiB

Previous results on branch: fix/close-scopes-before-replacing-options

Startup times

Revision Plain With Sentry Diff
e12b4d2 456.29 ms 543.46 ms 87.17 ms
a121565 474.11 ms 543.36 ms 69.25 ms

App size

Revision Plain With Sentry Diff
e12b4d2 1.70 MiB 2.35 MiB 669.05 KiB
a121565 1.70 MiB 2.35 MiB 669.05 KiB

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/spring-support-graphql-v22 to 8.x.x October 7, 2024 13:39
An error occurred while trying to automatically change base from feat/spring-support-graphql-v22 to 8.x.x October 7, 2024 13:39
@adinauer adinauer merged commit 8c90f98 into 8.x.x Oct 9, 2024
21 of 22 checks passed
@adinauer adinauer deleted the fix/close-scopes-before-replacing-options branch October 9, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants