POTEL 37b - No longer selectively copy OTel span attributes #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SpanDescriptionExtractor.java
…noring sentry specific ones
…PROCESS_COMMAND_ARGS
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bfc2f88 | 456.92 ms | 530.96 ms | 74.04 ms |
| 9294b06 | 438.15 ms | 502.29 ms | 64.15 ms |
| 33d3c1b | 349.24 ms | 358.60 ms | 9.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bfc2f88 | 1.70 MiB | 2.29 MiB | 599.45 KiB |
| 9294b06 | 1.70 MiB | 2.29 MiB | 599.31 KiB |
| 33d3c1b | 1.70 MiB | 2.29 MiB | 599.45 KiB |
Base automatically changed from
feat/POTEL-37-add-attributes-to-span-data
to
8.x.x
September 2, 2024 09:23
An error occurred while trying to automatically change base from
feat/POTEL-37-add-attributes-to-span-data
to
8.x.x
September 2, 2024 09:23
lbloder
reviewed
Sep 2, 2024
| @@ -21,35 +19,6 @@ public final class SpanDescriptionExtractor { | |||
| @SuppressWarnings("deprecation") | |||
| public @NotNull OtelSpanInfo extractSpanInfo( | |||
There was a problem hiding this comment.
Is the TODO above this method still relevant?
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ | |||
| - Use OpenTelemetry span name as fallback for transaction name ([#3557](https://github.com/getsentry/sentry-java/pull/3557)) | |||
| - In certain cases we were sending transactions as "<unlabeled transaction>" when using OpenTelemetry | |||
| - Add OpenTelemetry span data to Sentry span ([#3593](https://github.com/getsentry/sentry-java/pull/3593)) | |||
| - No longer selectively copy OpenTelemetry attributes to Sentry spans `data` ([#3663](https://github.com/getsentry/sentry-java/pull/3663)) | |||
There was a problem hiding this comment.
Should we also include the fact, that we no longer set the span data on the transaction data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
We're copying all of attribues as of (#3593). This means we no longer need to selectively copy some of them.
💡 Motivation and Context
Remove unnecessary code.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps