Hubs/Scopes Merge 11 - Replace IHub with IScopes in Spring 5 / Spring Boot 2 integrations
#3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
7 tasks
Performance metrics 🚀
|
lbloder
reviewed
Apr 5, 2024
sentry-spring/src/main/java/io/sentry/spring/webflux/SentryWebFilter.java
Show resolved
Hide resolved
lbloder
reviewed
Apr 5, 2024
| @@ -114,7 +114,7 @@ static class HubConfiguration { | |||
| } | |||
|
|
|||
| @Bean | |||
| public @NotNull IHub sentryHub( | |||
| public @NotNull IScopes sentryHub( | |||
There was a problem hiding this comment.
Should we rename this method?
markushi
approved these changes
Apr 15, 2024
markushi
approved these changes
Apr 15, 2024
Base automatically changed from
feat/hsm-10-replacements-in-otel-integration
to
8.x.x
April 16, 2024 14:42
|
We need to test whether renaming Spring beans and config classes breaks anything. Even then user code could break by renaming them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Follow up for #3297 changing Spring 5 / Spring Boot 2 integrations.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps