Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not eligible for auto proxying warnings #3154

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Fix not eligible for auto proxying warnings #3154

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edca50f
mark all aop related configurations and beans with @Role infrastructu…
lbloder Jan 22, 2024
3264f87
Format code
getsentry-bot Jan 22, 2024
2f1733a
add changelog
lbloder Jan 22, 2024
bcaf91d
make api
lbloder Jan 22, 2024
9f30d1c
restore advice constructors
adinauer Jan 23, 2024
bbcd8a1
fix tests
lbloder Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format code
  • Loading branch information
@getsentry-bot
getsentry-bot committed Jan 22, 2024
commit 3264f87efb13c172fe33a977bbcf7c51b7be561b
1 change: 0 additions & 1 deletion ...ry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/checkin/SentryCheckInAdvice.java
View file
Original file line number Diff line number Diff line change
@@ -8,7 +8,6 @@
import io.sentry.IHub;
import io.sentry.SentryLevel;
import io.sentry.protocol.SentryId;
import io.sentry.util.Objects;
import io.sentry.util.TracingUtils;
import java.lang.reflect.Method;
import org.aopalliance.intercept.MethodInterceptor;
1 change: 0 additions & 1 deletion ...arta/src/main/java/io/sentry/spring/jakarta/checkin/SentryCheckInAdviceConfiguration.java
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.sentry.spring.jakarta.checkin;

import com.jakewharton.nopen.annotation.Open;
import io.sentry.IHub;
import org.aopalliance.aop.Advice;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.NotNull;
2 changes: 0 additions & 2 deletions ...c/main/java/io/sentry/spring/jakarta/exception/SentryCaptureExceptionParameterAdvice.java
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package io.sentry.spring.jakarta.exception;

import com.jakewharton.nopen.annotation.Open;

import io.sentry.HubAdapter;
import io.sentry.IHub;
import io.sentry.exception.ExceptionMechanismException;
import io.sentry.protocol.Mechanism;
import io.sentry.util.Objects;
import java.lang.reflect.Method;
import org.aopalliance.intercept.MethodInterceptor;
import org.aopalliance.intercept.MethodInvocation;
3 changes: 1 addition & 2 deletions .../java/io/sentry/spring/jakarta/exception/SentryExceptionParameterAdviceConfiguration.java
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.sentry.spring.jakarta.exception;

import com.jakewharton.nopen.annotation.Open;
import io.sentry.IHub;
import org.aopalliance.aop.Advice;
import org.jetbrains.annotations.NotNull;
import org.springframework.aop.Advisor;
@@ -17,7 +16,7 @@
@Configuration(proxyBeanMethods = false)
@Open
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
public class SentryExceptionParameterAdviceConfiguration {
public class SentryExceptionParameterAdviceConfiguration {

@Bean
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
1 change: 0 additions & 1 deletion ...ing-jakarta/src/main/java/io/sentry/spring/jakarta/tracing/SentryAdviceConfiguration.java
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.sentry.spring.jakarta.tracing;

import com.jakewharton.nopen.annotation.Open;
import io.sentry.IHub;
import org.aopalliance.aop.Advice;
import org.jetbrains.annotations.NotNull;
import org.springframework.aop.Advisor;
2 changes: 0 additions & 2 deletions sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/tracing/SentrySpanAdvice.java
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package io.sentry.spring.jakarta.tracing;

import com.jakewharton.nopen.annotation.Open;

import io.sentry.HubAdapter;
import io.sentry.IHub;
import io.sentry.ISpan;
import io.sentry.SpanStatus;
import io.sentry.util.Objects;
import java.lang.reflect.Method;
import org.aopalliance.intercept.MethodInterceptor;
import org.aopalliance.intercept.MethodInvocation;
3 changes: 0 additions & 3 deletions ...pring-jakarta/src/main/java/io/sentry/spring/jakarta/tracing/SentryTransactionAdvice.java
View file
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
package io.sentry.spring.jakarta.tracing;

import com.jakewharton.nopen.annotation.Open;

import io.sentry.HubAdapter;
import io.sentry.IHub;
import io.sentry.ITransaction;
import io.sentry.SpanStatus;
import io.sentry.TransactionContext;
import io.sentry.TransactionOptions;
import io.sentry.protocol.TransactionNameSource;
import io.sentry.util.Objects;
import java.lang.reflect.Method;
import org.aopalliance.intercept.MethodInterceptor;
import org.aopalliance.intercept.MethodInvocation;
@@ -35,7 +33,6 @@ public SentryTransactionAdvice() {
this.hub = HubAdapter.getInstance();
}


@SuppressWarnings("deprecation")
@Override
public Object invoke(final @NotNull MethodInvocation invocation) throws Throwable {
1 change: 0 additions & 1 deletion sentry-spring/src/main/java/io/sentry/spring/checkin/SentryCheckInAdvice.java
View file
Original file line number Diff line number Diff line change
@@ -8,7 +8,6 @@
import io.sentry.IHub;
import io.sentry.SentryLevel;
import io.sentry.protocol.SentryId;
import io.sentry.util.Objects;
import io.sentry.util.TracingUtils;
import java.lang.reflect.Method;
import org.aopalliance.intercept.MethodInterceptor;
1 change: 0 additions & 1 deletion sentry-spring/src/main/java/io/sentry/spring/checkin/SentryCheckInAdviceConfiguration.java
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.sentry.spring.checkin;

import com.jakewharton.nopen.annotation.Open;
import io.sentry.IHub;
import org.aopalliance.aop.Advice;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.NotNull;
2 changes: 0 additions & 2 deletions ...pring/src/main/java/io/sentry/spring/exception/SentryCaptureExceptionParameterAdvice.java
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package io.sentry.spring.exception;

import com.jakewharton.nopen.annotation.Open;

import io.sentry.HubAdapter;
import io.sentry.IHub;
import io.sentry.exception.ExceptionMechanismException;
import io.sentry.protocol.Mechanism;
import io.sentry.util.Objects;
import java.lang.reflect.Method;
import org.aopalliance.intercept.MethodInterceptor;
import org.aopalliance.intercept.MethodInvocation;
1 change: 0 additions & 1 deletion ...src/main/java/io/sentry/spring/exception/SentryExceptionParameterAdviceConfiguration.java
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.sentry.spring.exception;

import com.jakewharton.nopen.annotation.Open;
import io.sentry.IHub;
import org.aopalliance.aop.Advice;
import org.jetbrains.annotations.NotNull;
import org.springframework.aop.Advisor;
1 change: 0 additions & 1 deletion sentry-spring/src/main/java/io/sentry/spring/tracing/SentryAdviceConfiguration.java
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.sentry.spring.tracing;

import com.jakewharton.nopen.annotation.Open;
import io.sentry.IHub;
import org.aopalliance.aop.Advice;
import org.jetbrains.annotations.NotNull;
import org.springframework.aop.Advisor;
2 changes: 0 additions & 2 deletions sentry-spring/src/main/java/io/sentry/spring/tracing/SentrySpanAdvice.java
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package io.sentry.spring.tracing;

import com.jakewharton.nopen.annotation.Open;

import io.sentry.HubAdapter;
import io.sentry.IHub;
import io.sentry.ISpan;
import io.sentry.SpanStatus;
import io.sentry.util.Objects;
import java.lang.reflect.Method;
import org.aopalliance.intercept.MethodInterceptor;
import org.aopalliance.intercept.MethodInvocation;
2 changes: 0 additions & 2 deletions sentry-spring/src/main/java/io/sentry/spring/tracing/SentryTransactionAdvice.java
View file
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
package io.sentry.spring.tracing;

import com.jakewharton.nopen.annotation.Open;

import io.sentry.HubAdapter;
import io.sentry.IHub;
import io.sentry.ITransaction;
import io.sentry.SpanStatus;
import io.sentry.TransactionContext;
import io.sentry.TransactionOptions;
import io.sentry.protocol.TransactionNameSource;
import io.sentry.util.Objects;
import java.lang.reflect.Method;
import org.aopalliance.intercept.MethodInterceptor;
import org.aopalliance.intercept.MethodInvocation;