Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of "is not eligible for getting processed by all BeanPostProcessors" warnings in Spring Boot #3108

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

adinauer
Copy link
Member

📜 Description

Set SentryGraphqlBeanPostProcessor to run last so it does not trigger "is not eligible for getting processed by all BeanPostProcessors" warnings.

💡 Motivation and Context

Fixes #3042

💚 How did you test it?

Manually using Spring Boot samples.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 18, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 958866d

Copy link
Contributor

github-actions bot commented Dec 18, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 384.46 ms 460.51 ms 76.05 ms
Size 1.72 MiB 2.27 MiB 558.28 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8838e01 387.41 ms 467.00 ms 79.59 ms
4e260b3 384.08 ms 477.56 ms 93.48 ms
93a76ca 377.41 ms 448.22 ms 70.81 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
86f0096 368.63 ms 446.92 ms 78.29 ms
0404ea3 332.47 ms 401.12 ms 68.66 ms
b172d4e 412.60 ms 492.68 ms 80.08 ms
93a76ca 397.30 ms 455.16 ms 57.87 ms
8ff8fd0 432.77 ms 495.18 ms 62.41 ms
7eccfdb 389.94 ms 461.29 ms 71.35 ms

App size

Revision Plain With Sentry Diff
8838e01 1.72 MiB 2.29 MiB 578.15 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
8ff8fd0 1.72 MiB 2.27 MiB 558.15 KiB
7eccfdb 1.72 MiB 2.27 MiB 556.93 KiB

Previous results on branch: feat/not-eligible-warning

Startup times

Revision Plain With Sentry Diff
03c8783 418.55 ms 514.10 ms 95.55 ms
5aaac99 428.82 ms 508.04 ms 79.22 ms

App size

Revision Plain With Sentry Diff
03c8783 1.72 MiB 2.27 MiB 558.21 KiB
5aaac99 1.72 MiB 2.27 MiB 558.22 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit c8e832b into main Dec 20, 2023
18 checks passed
@adinauer adinauer deleted the feat/not-eligible-warning branch December 20, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants