-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send SDK frames in case of crashes #3021
Conversation
@philipphofmann what would be the next step for ingesting crashes into the sentry org? I guess open a PR similar to this one? getsentry/sentry#59261 |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6684058 | 414.76 ms | 511.46 ms | 96.70 ms |
6a40795 | 370.00 ms | 437.33 ms | 67.33 ms |
ff784c6 | 388.51 ms | 461.90 ms | 73.39 ms |
db8763d | 386.60 ms | 453.66 ms | 67.06 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6684058 | 1.72 MiB | 2.26 MiB | 550.19 KiB |
6a40795 | 1.72 MiB | 2.26 MiB | 550.26 KiB |
ff784c6 | 1.72 MiB | 2.26 MiB | 550.22 KiB |
db8763d | 1.72 MiB | 2.26 MiB | 550.22 KiB |
Codecov ReportAttention:
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
I will collect all PRs and issues necessary to achieve this here getsentry/sentry#59263. Ideally, yes this PR and adding a config like this one https://github.com/getsentry/sentry/blob/4cef591aaa40a3579089da89b24a0fac12ce72e5/src/sentry/utils/sdk_crashes/cocoa_sdk_crash_detector.py, create a project in Sentry for the Java/Android crashes with some grouping rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, LGTM!
📜 Description
Here's a sample event for testing https://sentry-sdks.sentry.io/issues/4595173909/events/ea05056bfc2b4f42ae04df91a4745881/
💡 Motivation and Context
Closes #2758
💚 How did you test it?
Manually and automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps