-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for ignoring certain monitor slugs #2943
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add option for ignoring certain monitor slugs ([#2943](https://github.com/getsentry/sentry-java/pull/2943)) If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6ed3382 | 326.87 ms | 384.59 ms | 57.71 ms |
025e762 | 308.65 ms | 348.98 ms | 40.33 ms |
3bb19ba | 369.70 ms | 487.59 ms | 117.89 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6ed3382 | 1.72 MiB | 2.29 MiB | 576.11 KiB |
025e762 | 1.72 MiB | 2.29 MiB | 576.11 KiB |
3bb19ba | 1.72 MiB | 2.29 MiB | 576.11 KiB |
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, LGTM otherwise 👍
sentry-samples/sentry-samples-spring-boot/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...ng-boot-jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/SentryAutoConfigurationTest.kt
Show resolved
Hide resolved
sentry-spring-boot/src/test/kotlin/io/sentry/spring/boot/SentryAutoConfigurationTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Add the following options:
enableAutomaticCheckIns
which enables automatic Check-ins, e.g. Quartz; defaults tofalse
meaning it's disabledignoredCheckIns
which can be used to set a list of monitor slugs and regular expressions matching on the Check-ins monitor slug. These will then be dropped inSentryClient
.💡 Motivation and Context
Opt-in to automatic check-ins and a way to filter check-ins.
💚 How did you test it?
Manually + unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps