-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix native-only thread dump parsing and tracingContext for ANRv2 #2839
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9246ed4 | 275.63 ms | 321.31 ms | 45.69 ms |
f274c79 | 334.86 ms | 348.54 ms | 13.68 ms |
c03a05e | 390.40 ms | 419.35 ms | 28.94 ms |
9246ed4 | 281.79 ms | 352.08 ms | 70.29 ms |
8820c5c | 330.60 ms | 416.86 ms | 86.26 ms |
adf8fe3 | 300.49 ms | 357.36 ms | 56.87 ms |
0310da5 | 381.20 ms | 404.50 ms | 23.30 ms |
dc67004 | 273.86 ms | 346.37 ms | 72.51 ms |
496bdfd | 272.86 ms | 407.33 ms | 134.48 ms |
caf50ec | 302.36 ms | 325.25 ms | 22.89 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
f274c79 | 1.72 MiB | 2.29 MiB | 575.01 KiB |
c03a05e | 1.72 MiB | 2.29 MiB | 574.43 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
8820c5c | 1.72 MiB | 2.28 MiB | 571.82 KiB |
adf8fe3 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
0310da5 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
dc67004 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
caf50ec | 1.72 MiB | 2.29 MiB | 575.24 KiB |
Previous results on branch: rz/fix/thread-dump-parse
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2623c43 | 317.96 ms | 380.75 ms | 62.79 ms |
d1f8806 | 353.04 ms | 406.71 ms | 53.67 ms |
bbfb000 | 332.48 ms | 381.57 ms | 49.10 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2623c43 | 1.72 MiB | 2.29 MiB | 575.52 KiB |
d1f8806 | 1.72 MiB | 2.29 MiB | 575.52 KiB |
bbfb000 | 1.72 MiB | 2.29 MiB | 575.48 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
============================================
+ Coverage 81.29% 81.30% +0.01%
- Complexity 4565 4569 +4
============================================
Files 351 351
Lines 16874 16891 +17
Branches 2272 2276 +4
============================================
+ Hits 13717 13733 +16
+ Misses 2216 2215 -1
- Partials 941 943 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
📜 Description
💡 Motivation and Context
💚 How did you test it?
Manually and automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps