Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native-only thread dump parsing and tracingContext for ANRv2 #2839

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jul 13, 2023

📜 Description

  • Fixes thread dump parsing for native-only thread dumps
  • Fixes TracingContext envelope header for ANRv2 events (we derive values from the backfillable event now instead of Scope)

💡 Motivation and Context

💚 How did you test it?

Manually and automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 393.49 ms 434.60 ms 41.11 ms
Size 1.72 MiB 2.29 MiB 575.52 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9246ed4 275.63 ms 321.31 ms 45.69 ms
f274c79 334.86 ms 348.54 ms 13.68 ms
c03a05e 390.40 ms 419.35 ms 28.94 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms
8820c5c 330.60 ms 416.86 ms 86.26 ms
adf8fe3 300.49 ms 357.36 ms 56.87 ms
0310da5 381.20 ms 404.50 ms 23.30 ms
dc67004 273.86 ms 346.37 ms 72.51 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
caf50ec 302.36 ms 325.25 ms 22.89 ms

App size

Revision Plain With Sentry Diff
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
c03a05e 1.72 MiB 2.29 MiB 574.43 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB
adf8fe3 1.72 MiB 2.29 MiB 575.24 KiB
0310da5 1.72 MiB 2.28 MiB 573.45 KiB
dc67004 1.72 MiB 2.28 MiB 573.45 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
caf50ec 1.72 MiB 2.29 MiB 575.24 KiB

Previous results on branch: rz/fix/thread-dump-parse

Startup times

Revision Plain With Sentry Diff
2623c43 317.96 ms 380.75 ms 62.79 ms
d1f8806 353.04 ms 406.71 ms 53.67 ms
bbfb000 332.48 ms 381.57 ms 49.10 ms

App size

Revision Plain With Sentry Diff
2623c43 1.72 MiB 2.29 MiB 575.52 KiB
d1f8806 1.72 MiB 2.29 MiB 575.52 KiB
bbfb000 1.72 MiB 2.29 MiB 575.48 KiB

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: +0.01 🎉

Comparison is base (cf31d19) 81.29% compared to head (7612a62) 81.30%.

❗ Current head 7612a62 differs from pull request most recent head d91a715. Consider uploading reports for the commit d91a715 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2839      +/-   ##
============================================
+ Coverage     81.29%   81.30%   +0.01%     
- Complexity     4565     4569       +4     
============================================
  Files           351      351              
  Lines         16874    16891      +17     
  Branches       2272     2276       +4     
============================================
+ Hits          13717    13733      +16     
+ Misses         2216     2215       -1     
- Partials        941      943       +2     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryClient.java 87.99% <83.33%> (-0.10%) ⬇️
sentry/src/main/java/io/sentry/Baggage.java 89.28% <91.66%> (+0.69%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@romtsn romtsn enabled auto-merge (squash) July 17, 2023 07:37
@romtsn romtsn merged commit 3baa73f into main Jul 17, 2023
@romtsn romtsn deleted the rz/fix/thread-dump-parse branch July 17, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants