-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open up some transaction methods #2701
Conversation
|
…y/sentry-java into feat/public-transaction-methods
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2a22604 | 291.21 ms | 342.83 ms | 51.62 ms |
1212d48 | 419.29 ms | 484.16 ms | 64.88 ms |
b91be82 | 345.02 ms | 365.88 ms | 20.86 ms |
3b09b8a | 323.26 ms | 369.64 ms | 46.38 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2a22604 | 1.72 MiB | 2.28 MiB | 565.45 KiB |
1212d48 | 1.72 MiB | 2.28 MiB | 565.45 KiB |
b91be82 | 1.72 MiB | 2.28 MiB | 565.45 KiB |
3b09b8a | 1.72 MiB | 2.28 MiB | 565.45 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
============================================
+ Coverage 81.05% 81.07% +0.02%
- Complexity 4427 4432 +5
============================================
Files 345 345
Lines 16356 16358 +2
Branches 2219 2219
============================================
+ Hits 13258 13263 +5
+ Misses 2170 2167 -3
Partials 928 928
☔ View full report in Codecov by Sentry. |
Hey @romtsn, I missed removing the Thanks |
looks good, thanks @lbloder ! |
📜 Description
Open up some transaction methods, so that they can be used from outside sentry
Add new
startChild
method to set timestamp💡 Motivation and Context
Fixes #2640
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps