-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timestamps of PerformanceCollectionData in profiles #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be relative to the profile start
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
33c80c7 | 318.88 ms | 348.14 ms | 29.26 ms |
17ab223 | 427.65 ms | 484.31 ms | 56.65 ms |
33c80c7 | 331.94 ms | 370.54 ms | 38.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
17ab223 | 1.73 MiB | 2.34 MiB | 626.85 KiB |
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
Previous results on branch: fix/perfomance-data-timestamps-profiles
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d8599b0 | 352.98 ms | 401.02 ms | 48.04 ms |
f8f2181 | 295.63 ms | 358.49 ms | 62.86 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d8599b0 | 1.73 MiB | 2.26 MiB | 551.12 KiB |
f8f2181 | 1.73 MiB | 2.26 MiB | 551.12 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2632 +/- ##
=========================================
Coverage 81.37% 81.37%
- Complexity 4221 4222 +1
=========================================
Files 337 337
Lines 15601 15602 +1
Branches 2037 2037
=========================================
+ Hits 12695 12696 +1
Misses 2111 2111
Partials 795 795
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
romtsn
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
PerformanceCollectionData timestamps in profiles have been adjusted to be relative to the profile start
💡 Motivation and Context
PerformanceCollectionData timestamps were absolute values, but they were supposed to be relative to the profile start
💚 How did you test it?
Added a Ui test
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps