-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add main
flag to threads and in_foreground
flag for app contexts
#2516
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5fa24ec | 326.29 ms | 384.53 ms | 58.24 ms |
c1399c1 | 345.06 ms | 385.49 ms | 40.43 ms |
754021c | 358.70 ms | 361.98 ms | 3.28 ms |
14c083a | 350.82 ms | 388.86 ms | 38.04 ms |
f6a135d | 263.96 ms | 383.59 ms | 119.63 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5fa24ec | 1.73 MiB | 2.33 MiB | 620.61 KiB |
c1399c1 | 1.73 MiB | 2.33 MiB | 620.61 KiB |
754021c | 1.73 MiB | 2.33 MiB | 623.06 KiB |
14c083a | 1.73 MiB | 2.33 MiB | 620.61 KiB |
f6a135d | 1.73 MiB | 2.33 MiB | 623.10 KiB |
Previous results on branch: feat/main-thread-foreground-app
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
640c424 | 359.73 ms | 388.98 ms | 29.24 ms |
029bd19 | 327.79 ms | 378.85 ms | 51.06 ms |
a4ccef1 | 300.85 ms | 321.66 ms | 20.81 ms |
4edebf2 | 312.88 ms | 372.92 ms | 60.04 ms |
7133791 | 328.92 ms | 360.87 ms | 31.95 ms |
885ac80 | 307.27 ms | 352.98 ms | 45.71 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
640c424 | 1.73 MiB | 2.33 MiB | 623.16 KiB |
029bd19 | 1.73 MiB | 2.33 MiB | 623.17 KiB |
a4ccef1 | 1.73 MiB | 2.33 MiB | 623.16 KiB |
4edebf2 | 1.73 MiB | 2.33 MiB | 623.17 KiB |
7133791 | 1.73 MiB | 2.33 MiB | 623.16 KiB |
885ac80 | 1.73 MiB | 2.33 MiB | 623.17 KiB |
Codecov ReportBase: 80.18% // Head: 80.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2516 +/- ##
============================================
+ Coverage 80.18% 80.19% +0.01%
- Complexity 3943 3948 +5
============================================
Files 323 323
Lines 14896 14911 +15
Branches 1965 1967 +2
============================================
+ Hits 11944 11958 +14
- Misses 2178 2179 +1
Partials 774 774
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
Looking good 👍 , if you need any help on the TODOs around the thread |
lgtm as well |
main
flag to threads and in_foreground
flag for app contexts
…getsentry/sentry-java into feat/main-thread-foreground-app
// This should not be set by Hybrid SDKs since they have their own app's lifecycle | ||
if (!HintUtils.isFromHybridSdk(hint) && app.getInForeground() == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running into #2525
// This should not be set by Hybrid SDKs since they have their own threading model | ||
if (!isHybridSDK && thread.isMain() == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
📜 Description
Add main flag to threads and in_foreground flag for app contexts
💡 Motivation and Context
Relates to getsentry/team-mobile#36
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps