-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abnormal_mechanism to sessions for ANR rate calculation #2475
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b872136 | 334.37 ms | 349.40 ms | 15.03 ms |
82a9a16 | 354.77 ms | 393.67 ms | 38.90 ms |
aa715bc | 335.65 ms | 384.90 ms | 49.25 ms |
61ea1d3 | 312.40 ms | 346.45 ms | 34.05 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b872136 | 1.73 MiB | 2.33 MiB | 619.69 KiB |
82a9a16 | 1.73 MiB | 2.33 MiB | 619.69 KiB |
aa715bc | 1.73 MiB | 2.33 MiB | 619.65 KiB |
61ea1d3 | 1.73 MiB | 2.33 MiB | 619.69 KiB |
Codecov ReportBase: 80.13% // Head: 80.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2475 +/- ##
============================================
+ Coverage 80.13% 80.16% +0.02%
- Complexity 3873 3882 +9
============================================
Files 312 313 +1
Lines 14672 14695 +23
Branches 1943 1947 +4
============================================
+ Hits 11758 11780 +22
- Misses 2153 2154 +1
Partials 761 761
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, LGTM!
📜 Description
This PR contains 3 main changes:
abnormal_mechanism
to the Session payload, which is set when user experienced an ANR event and which is used for ANR rate calculation on the product side💡 Motivation and Context
Q1 Goal (ANR rate and improvements)
💚 How did you test it?
Manually and automated
📝 Checklist
🔮 Next steps