Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 6.4 hotfix back into main #2275

Merged
merged 9 commits into from
Oct 6, 2022
Merged

Merge 6.4 hotfix back into main #2275

merged 9 commits into from
Oct 6, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Oct 5, 2022

#skip-changelog

Co-authored-by: Philipp Hofmann philipp.hofmann@sentry.io## 📜 Description

💡 Motivation and Context

Contains hotfix for broken slow/frozen frames.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

adinauer and others added 4 commits September 30, 2022 19:47
This reverts commit bb1d054.
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 372.04 ms 429.63 ms 57.59 ms
Size 1.73 MiB 2.29 MiB 579.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7300956 337.57 ms 384.21 ms 46.64 ms
7300956 324.20 ms 353.79 ms 29.58 ms
c5ccd8a 329.98 ms 365.52 ms 35.54 ms
1e4690d 354.69 ms 387.88 ms 33.19 ms
2f079a1 296.91 ms 337.43 ms 40.51 ms
3d89dea 322.38 ms 350.82 ms 28.45 ms
54cebc8 331.12 ms 385.14 ms 54.02 ms
3d89dea 345.59 ms 364.06 ms 18.47 ms
54cebc8 300.86 ms 341.43 ms 40.57 ms

App size

Revision Plain With Sentry Diff
7300956 1.73 MiB 2.29 MiB 578.69 KiB
7300956 1.73 MiB 2.29 MiB 578.69 KiB
c5ccd8a 1.74 MiB 2.33 MiB 607.44 KiB
1e4690d 1.74 MiB 2.33 MiB 604.92 KiB
2f079a1 1.74 MiB 2.33 MiB 605.56 KiB
3d89dea 1.74 MiB 2.33 MiB 604.92 KiB
54cebc8 1.73 MiB 2.29 MiB 579.43 KiB
3d89dea 1.74 MiB 2.33 MiB 604.92 KiB
54cebc8 1.73 MiB 2.29 MiB 579.43 KiB

Previous results on branch: 6.4.x

Startup times

Revision Plain With Sentry Diff
9a87290 318.37 ms 369.65 ms 51.27 ms
efa513a 322.63 ms 362.73 ms 40.10 ms

App size

Revision Plain With Sentry Diff
9a87290 1.73 MiB 2.29 MiB 579.49 KiB
efa513a 1.73 MiB 2.29 MiB 579.50 KiB

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 80.10% // Head: 80.10% // No change to project coverage 👍

Coverage data is based on head (589e677) compared to base (54cebc8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2275   +/-   ##
=========================================
  Coverage     80.10%   80.10%           
  Complexity     3423     3423           
=========================================
  Files           242      242           
  Lines         12692    12692           
  Branches       1698     1698           
=========================================
  Hits          10167    10167           
  Misses         1882     1882           
  Partials        643      643           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@philipphofmann
Copy link
Member

There are some merge conflicts. Are we sure this is PR is fine?

@philipphofmann
Copy link
Member

Ah ups, got resolved now.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer adinauer merged commit 5bfc1ca into main Oct 6, 2022
@adinauer adinauer deleted the 6.4.x branch October 6, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants