-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Timber and Fragment integrations if they are present on the classpath #1936
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1936 +/- ##
=========================================
Coverage 75.60% 75.60%
Complexity 2270 2270
=========================================
Files 225 225
Lines 8072 8072
Branches 852 852
=========================================
Hits 6103 6103
Misses 1558 1558
Partials 411 411 Continue to review full report at Codecov.
|
static final String SENTRY_FRAGMENT_INTEGRATION_CLASS_NAME =
"io.sentry.android.fragment.FragmentLifecycleIntegration";
static final String SENTRY_TIMBER_INTEGRATION_CLASS_NAME =
"io.sentry.android.timber.SentryTimberIntegration"; Are these class names excluded from R8 obfuscation? Otherwise these might not be found in Android Release builds at runtime. |
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AndroidOptionsInitializerTest.kt
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Show resolved
Hide resolved
...ry-android-fragment/src/main/java/io/sentry/android/fragment/FragmentLifecycleIntegration.kt
Outdated
Show resolved
Hide resolved
...ry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MyApplication.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Show resolved
Hide resolved
...ry-android-fragment/src/main/java/io/sentry/android/fragment/FragmentLifecycleIntegration.kt
Outdated
Show resolved
Hide resolved
@marandaneto addressed everything, PTAL once again |
@audkar thanks for raising the concern. Yes, we ship those modules with proguard rules that keep those classes, see here and here |
sentry-android-core/src/main/java/io/sentry/android/core/ActivityFramesTracker.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AndroidOptionsInitializerTest.kt
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/SentryAndroidTest.kt
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/LoadClass.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Show resolved
Hide resolved
...ry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MyApplication.java
Show resolved
Hide resolved
…lass.java Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
📜 Description
sentry-android-timber
andsentry-android-fragment
are on the classpath and adds the integrations automatically.💡 Motivation and Context
Q1 goal
💚 How did you test it?
📝 Checklist
🔮 Next steps