Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Kotlin 1.5 #1815

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Bump to Kotlin 1.5 #1815

merged 4 commits into from
Nov 23, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 18, 2021

📜 Description

should this go to Branch 6.0.0 due to Kotlin compatibility? (Only for Timber tho)

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@@ -16,7 +16,7 @@ configure<JavaPluginExtension> {

tasks.withType<KotlinCompile>().configureEach {
kotlinOptions.jvmTarget = JavaVersion.VERSION_1_8.toString()
kotlinOptions.languageVersion = Config.springKotlinCompatibleLanguageVersion
Copy link
Contributor Author

@marandaneto marandaneto Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maciejwalkowiak cant use 1.3 due to the functional interfaces, would that be a problem for Spring projects? since it has to be 1.3 right now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring now supports Kotlin 1.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but then I guess we'd need to bump Spring versions I guess?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a separate issue, I will merge, but we could bump the springKotlinCompatibleLanguageVersion libs to 1.4 if its already supported (under the v6 branch)

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #1815 (5d4d7d8) into 6.x.x (6bd9e14) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              6.x.x    #1815   +/-   ##
=========================================
  Coverage     80.93%   80.93%           
  Complexity     2850     2850           
=========================================
  Files           207      207           
  Lines         10475    10475           
  Branches       1380     1380           
=========================================
  Hits           8478     8478           
  Misses         1510     1510           
  Partials        487      487           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd9e14...5d4d7d8. Read the comment docs.

@marandaneto marandaneto changed the base branch from main to 6.x.x November 23, 2021 08:35
@marandaneto marandaneto merged commit 1ea60dc into 6.x.x Nov 23, 2021
@marandaneto marandaneto deleted the bump/kotlin1.5 branch November 23, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants