-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Kotlin 1.5 #1815
Bump to Kotlin 1.5 #1815
Conversation
@@ -16,7 +16,7 @@ configure<JavaPluginExtension> { | |||
|
|||
tasks.withType<KotlinCompile>().configureEach { | |||
kotlinOptions.jvmTarget = JavaVersion.VERSION_1_8.toString() | |||
kotlinOptions.languageVersion = Config.springKotlinCompatibleLanguageVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maciejwalkowiak cant use 1.3 due to the functional interfaces, would that be a problem for Spring projects? since it has to be 1.3 right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring now supports Kotlin 1.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but then I guess we'd need to bump Spring versions I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is a separate issue, I will merge, but we could bump the springKotlinCompatibleLanguageVersion
libs to 1.4 if its already supported (under the v6 branch)
Codecov Report
@@ Coverage Diff @@
## 6.x.x #1815 +/- ##
=========================================
Coverage 80.93% 80.93%
Complexity 2850 2850
=========================================
Files 207 207
Lines 10475 10475
Branches 1380 1380
=========================================
Hits 8478 8478
Misses 1510 1510
Partials 487 487 Continue to review full report at Codecov.
|
📜 Description
should this go to Branch 6.0.0 due to Kotlin compatibility? (Only for Timber tho)
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps