Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Window.FEATURE_NO_TITLE does not work when using activity traces #1769

Merged
merged 5 commits into from
Oct 18, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

* Fix: Window.FEATURE_NO_TITLE does not work when using activity traces (#1769)

## 5.2.3

* Fix: Make ActivityFramesTracker operations thread-safe (#1762)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ private void finishTransaction(final @Nullable ITransaction transaction) {
@Override
public synchronized void onActivityCreated(
final @NonNull Activity activity, final @Nullable Bundle savedInstanceState) {
activityFramesTracker.addActivity(activity);
setColdStart(savedInstanceState);
addBreadcrumb(activity, "created");
startTracing(activity);
Expand All @@ -237,6 +236,10 @@ public synchronized void onActivityCreated(

@Override
public synchronized void onActivityStarted(final @NonNull Activity activity) {
// the screen rendering measurements start for every Activity class when the app calls
// onActivityStarted
marandaneto marked this conversation as resolved.
Show resolved Hide resolved
activityFramesTracker.addActivity(activity);

addBreadcrumb(activity, "started");
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ class ActivityLifecycleIntegrationTest {
sut.register(fixture.hub, fixture.options)

val activity = mock<Activity>()
sut.onActivityCreated(activity, fixture.bundle)
sut.onActivityStarted(activity)

verify(fixture.activityFramesTracker).addActivity(eq(activity))
}
Expand Down