Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Graceful Shutdown flushes event instead of Closing SDK #1500

Merged
merged 5 commits into from
May 31, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 31, 2021

📜 Description

Fix: Graceful Shutdown flushes event instead of Closing SDK

💡 Motivation and Context

Fix #1458

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #1500 (de02542) into main (fd64cc0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1500      +/-   ##
============================================
+ Coverage     76.00%   76.03%   +0.02%     
- Complexity     1926     1929       +3     
============================================
  Files           191      191              
  Lines          6665     6673       +8     
  Branches        663      664       +1     
============================================
+ Hits           5066     5074       +8     
  Misses         1274     1274              
  Partials        325      325              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryOptions.java 84.63% <100.00%> (+0.18%) ⬆️
...c/main/java/io/sentry/ShutdownHookIntegration.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd64cc0...de02542. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tyrrrz we need the same thing in .NET. Basically Dispose should only flush, particularly from Unity and ASP.NET Core and other integrations application shutdown hook where we don't guarantee we're the last thing to shut down.

@marandaneto marandaneto merged commit 90984b2 into main May 31, 2021
@marandaneto marandaneto deleted the fix/graceful-shutdown branch May 31, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting Graceful Shutdown
3 participants