Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add secondary constructor to SentryOkHttpInterceptor #1491

Merged
merged 3 commits into from
May 27, 2021
Merged

Feat: Add secondary constructor to SentryOkHttpInterceptor #1491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f9772c
Feat: Add secondary constructor to SentryOkHttpInterceptor
maciejwalkowiak May 26, 2021
24520ec
Changelog.
maciejwalkowiak May 26, 2021
2c76333
Merge branch 'main' into okhttp-constructor
marandaneto May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased

* Feat: Add secondary constructor to SentryOkHttpInterceptor (#1491)
* Feat: Add option to enable debug mode in Log4j2 integration (#1492)

# 5.0.0-beta.5
Expand Down
1 change: 1 addition & 0 deletions sentry-android-okhttp/api/sentry-android-okhttp.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public final class io/sentry/android/okhttp/SentryOkHttpInterceptor : okhttp3/In
public fun <init> ()V
public fun <init> (Lio/sentry/IHub;Lio/sentry/android/okhttp/SentryOkHttpInterceptor$BeforeSpanCallback;)V
public synthetic fun <init> (Lio/sentry/IHub;Lio/sentry/android/okhttp/SentryOkHttpInterceptor$BeforeSpanCallback;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun <init> (Lio/sentry/android/okhttp/SentryOkHttpInterceptor$BeforeSpanCallback;)V
public fun intercept (Lokhttp3/Interceptor$Chain;)Lokhttp3/Response;
}

Expand Down
2 changes: 2 additions & 0 deletions sentry-android-okhttp/src/main/java/io/sentry/android/okhttp/SentryOkHttpInterceptor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ class SentryOkHttpInterceptor(
private val beforeSpan: BeforeSpanCallback? = null
) : Interceptor {

constructor(beforeSpan: BeforeSpanCallback) : this(HubAdapter.getInstance(), beforeSpan)
marandaneto marked this conversation as resolved.
Show resolved Hide resolved

override fun intercept(chain: Interceptor.Chain): Response {
var request = chain.request()

Expand Down