Fix: set correct transaction status for unhandled exceptions in SentryTracingFilter.
#1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Apr 14, 2021
sentry-spring/src/main/java/io/sentry/spring/tracing/SentryTracingFilter.java
Show resolved
Hide resolved
marandaneto
reviewed
Apr 14, 2021
| @@ -67,16 +67,22 @@ protected void doFilterInternal( | |||
| final ITransaction transaction = startTransaction(httpRequest, sentryTraceHeader); | |||
| try { | |||
| filterChain.doFilter(httpRequest, httpResponse); | |||
| } catch (Exception e) { | |||
| // exceptions that are not handled by Spring | |||
| transaction.setStatus(SpanStatus.INTERNAL_ERROR); | |||
There was a problem hiding this comment.
should we transaction.setThrowable(e) and throw e;?
There was a problem hiding this comment.
There is no need to setThrowable as the exception is captured while transaction is active - SentryClient sets the span context on the event.
Codecov Report
@@ Coverage Diff @@
## main #1406 +/- ##
============================================
+ Coverage 75.76% 75.77% +0.01%
- Complexity 1864 1865 +1
============================================
Files 185 185
Lines 6383 6387 +4
Branches 636 637 +1
============================================
+ Hits 4836 4840 +4
Misses 1258 1258
Partials 289 289
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: set correct transaction status for unhandled exceptions in
SentryTracingFilter.💡 Motivation and Context
For exceptions that have not been handled with
@ControllerAdviceor@ExceptionHandler, theresponse#statusinSentryTracingFilteris equal to200, which results in settingSpanStatus.OKon transaction.With this change, we handle also the case when the exception is not handled and set correct status code.
💚 How did you test it?
Unit tests.
📝 Checklist