Device context for transactions #1381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Apr 7, 2021
Comment on lines
6
to
10
| // other approach is to use EventProcessor<T extends SentryBaseEvent> | ||
| // and having a processor which is the common fields and specific processors for Event and Transactions | ||
| // not sure if our event processor interface should be deal with this | ||
| // the downside using only the base class, if people want to process a field which is not part of SentryBaseEvent | ||
| // they need to cast it manually |
There was a problem hiding this comment.
@bruno-garcia can we discuss this
There was a problem hiding this comment.
after the discussion, we could try to use default methods for interfaces, return it so it's not a breaking change.
4 tasks
|
favor of #1430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps