Fix: set "java" platform to transactions

[maciejwalkowiak]

📜 Description

Fix: set "java" platform to transactions

💡 Motivation and Context

Each event/transaction that SDK sends should have platform set.

💚 How did you test it?

Unit tests.

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• No breaking changes

[maciejwalkowiak]

The alternative implementation that I think I would be in favour of is that SentryBaseEvent#platform is set to "java" by default when object is created. This way we could mark it as @NotNull and just let user overwrite it with non-null values if needed.

If it's not something that users should be able to overwrite we could then remove the setter completely. What do you think @bruno-garcia @marandaneto

[marandaneto]

The alternative implementation that I think I would be in favour of is that SentryBaseEvent#platform is set to "java" by default when object is created. This way we could mark it as @NotNull and just let user overwrite it with non-null values if needed.

If it's not something that users should be able to overwrite we could then remove the setter completely. What do you think @bruno-garcia @marandaneto

better not, we also capture events from native platforms (Android NDK), it's important to know if there was a value, or not.
I think Gson would overwrite anyway but seems wrong.

[maciejwalkowiak]

But do we set different value for NDK? The javadocs says:

Acceptable values are: `as3`, `c`, `cfml`, `cocoa`, `csharp`, `elixir`, `haskell`, `go`,
   * `groovy`, `java`, `javascript`, `native`, `node`, `objc`, `other`, `perl`, `php`, `python`,
   * `ruby`

[codecov-io]

Codecov Report

Merging #1332 (7c8b49b) into main (fa1b8b7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1332   +/-   ##
=========================================
  Coverage     75.64%   75.65%           
- Complexity     1842     1843    +1     
=========================================
  Files           185      185           
  Lines          6319     6321    +2     
  Branches        626      627    +1     
=========================================
+ Hits           4780     4782    +2     
  Misses         1254     1254           
  Partials        285      285           

Impacted Files	Coverage Δ	Complexity Δ
sentry/src/main/java/io/sentry/SentryEvent.java	69.89% <ø> (-0.95%)	42.00 <0.00> (-2.00)
...ry/src/main/java/io/sentry/MainEventProcessor.java	75.71% <100.00%> (ø)	24.00 <0.00> (ø)
...entry/src/main/java/io/sentry/SentryBaseEvent.java	84.44% <100.00%> (+1.11%)	23.00 <2.00> (+2.00)
sentry/src/main/java/io/sentry/SentryClient.java	88.09% <100.00%> (+0.08%)	83.00 <11.00> (+1.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1b8b7...7c8b49b. Read the comment docs.

[marandaneto]

But do we set different value for NDK? The javadocs says:

Acceptable values are: `as3`, `c`, `cfml`, `cocoa`, `csharp`, `elixir`, `haskell`, `go`,
   * `groovy`, `java`, `javascript`, `native`, `node`, `objc`, `other`, `perl`, `php`, `python`,
   * `ruby`

NDK events are native, Dart events are other, RN events are javascript

[maciejwalkowiak]

Ok, then PR is ready to review as it is.

[marandaneto]

LGTM

[bruno-garcia]

But do we set different value for NDK? The javadocs says:

Acceptable values are: `as3`, `c`, `cfml`, `cocoa`, `csharp`, `elixir`, `haskell`, `go`,
   * `groovy`, `java`, `javascript`, `native`, `node`, `objc`, `other`, `perl`, `php`, `python`,
   * `ruby`

NDK will use native