Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove misleading error logs #1222

Merged
merged 4 commits into from
Feb 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* Improve Kotlin compatibility for SdkVersion
* Feat: Support logging via JUL (#1211)
* Fix: Fix returning Sentry trace header from Span (#1217)
* Fix: Remove misleading error logs (#1222)

# 4.0.0

Expand Down
3 changes: 0 additions & 3 deletions sentry/src/main/java/io/sentry/Hub.java
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ public void setUser(final @Nullable User user) {
.log(SentryLevel.WARNING, "Instance is disabled and this 'setUser' call is a no-op.");
} else {
stack.peek().getScope().setUser(user);
options.getLogger().log(SentryLevel.FATAL, "Stack peek was null when setUser");
}
}

Expand All @@ -328,7 +327,6 @@ public void setFingerprint(final @NotNull List<String> fingerprint) {
options.getLogger().log(SentryLevel.WARNING, "setFingerprint called with null parameter.");
} else {
stack.peek().getScope().setFingerprint(fingerprint);
options.getLogger().log(SentryLevel.FATAL, "Stack peek was null when setFingerprint");
}
}

Expand All @@ -342,7 +340,6 @@ public void clearBreadcrumbs() {
"Instance is disabled and this 'clearBreadcrumbs' call is a no-op.");
} else {
stack.peek().getScope().clearBreadcrumbs();
options.getLogger().log(SentryLevel.FATAL, "Stack peek was null when clearBreadcrumbs");
}
}

Expand Down