-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use a different method to get strings from JNI #1214
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
=========================================
Coverage 74.57% 74.57%
Complexity 1713 1713
=========================================
Files 177 177
Lines 6029 6029
Branches 600 600
=========================================
Hits 4496 4496
Misses 1256 1256
Partials 277 277 Continue to review full report at Codecov.
|
@Swatinem currently this causes: |
@Swatinem can we close this? |
I think this would still be interesting to do, as I think the current way is a bit fragile. |
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
=========================================
Coverage 76.03% 76.03%
Complexity 1954 1954
=========================================
Files 192 192
Lines 6763 6763
Branches 675 675
=========================================
Hits 5142 5142
Misses 1294 1294
Partials 327 327 Continue to review full report at Codecov.
|
📜 Description
This uses a different method to get string contents from JNI into native options, and avoids excessive stack allocation.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps