-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: OutboxSender supports all envelope item types #1158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, just needing tests or there's something else?
runtime tests and unit tests, but looks straightforward, will finish today |
Codecov Report
@@ Coverage Diff @@
## main #1158 +/- ##
============================================
- Coverage 75.25% 75.22% -0.04%
- Complexity 1661 1663 +2
============================================
Files 173 173
Lines 5808 5820 +12
Branches 568 569 +1
============================================
+ Hits 4371 4378 +7
- Misses 1173 1177 +4
- Partials 264 265 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📜 Description
Feat: OutboxSender supports all envelope item types
💡 Motivation and Context
#1157 and #1103
💚 How did you test it?
📝 Checklist
🔮 Next steps