-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Set current thread only if theres no exceptions #1064
Conversation
This also helps with #984 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1064 +/- ##
=========================================
Coverage 72.95% 72.96%
- Complexity 1520 1523 +3
=========================================
Files 161 161
Lines 5461 5463 +2
Branches 550 551 +1
=========================================
+ Hits 3984 3986 +2
Misses 1187 1187
Partials 290 290
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
📢 Type of change
📜 Description
Fix: Set current thread only if theres no exceptions
💡 Motivation and Context
We'd like to set the default (current) thread if
attachStacktrace
is enabled and there are no exceptions only, exceptions have its own stack traces already.one of the use cases for this is events captured by hybrid SDKs like React-native or Flutter, the current thread will be always the File observer, and it doesn't make much sense.
💚 How did you test it?
📝 Checklist
🔮 Next steps