Main application hangs if it initializes a KafkaProducer with sentry-java 6.19.1

[tjerkw]

Integration

sentry

Java Version

eclipse-temurin:11-jre

Version

6.19.1 upwards

Steps to Reproduce

Build this file with sentry-sdk 6.19.1:

import org.apache.kafka.clients.producer.KafkaProducer

class ReproduceSentryIssue {
    private val kafkaProducer: KafkaProducer<String, String> =
        KafkaProducer(...)

    companion object {

        @JvmStatic
        fun main(args: Array<String>) {
             ReproduceSentryIssue()
        }
    }
}

Run it with a logback appender:

    <!-- Configure the Sentry appender, overriding the logging threshold to the WARN level -->
    <appender name="Sentry" class="io.sentry.logback.SentryAppender">
        <!-- Optionally change minimum Event level. Default for Events is ERROR -->
        <minimumEventLevel>WARN</minimumEventLevel>
        <!-- Optionally change minimum Breadcrumbs level. Default for Breadcrumbs is INFO -->
        <minimumBreadcrumbLevel>INFO</minimumBreadcrumbLevel>
    </appender>

Run it on docker image FROM eclipse-temurin:11-jre

Result:

• Main application never exists, it never returns.

Workaround: Downgrade to 6.18.1

Note: Also reproducable with 6.20.1

Expected Result

The application should cleanly exit

Actual Result

It hangs, only stops with CTRL-C

[adinauer]

Hello @tjerkw I'm able to reproduce. Will investigate.

I've modified our Logback sample. See https://github.com/getsentry/sentry-java/compare/feat/kafka-logback-repro for what I tried.

I combined this with a kafka server:

cat docker-compose.yml
version: "2"

services:
  kafka:
    image: docker.io/bitnami/kafka:3.4
    ports:
      - "9092:9092"
    volumes:
      - "kafka_data:/bitnami"
    environment:
      - ALLOW_PLAINTEXT_LISTENER=yes

volumes:
  kafka_data:
    driver: local

[adinauer]

Seems to be coming from our new ANR detection #2697

More specifically these method invocations:

sentry-java/sentry/src/main/java/io/sentry/Sentry.java

Lines 236 to 238 in e96a1b7

	notifyOptionsObservers(options);
	finalizePreviousSession(options, HubAdapter.getInstance());

Also this doesn't seem to be linked to Kafka. It's also happening in our Logback sample.

@tjerkw can you please try explicitly calling Sentry.close().

[adinauer]

These invocations should be fine but we're now replacing the ExecutorService. We shouldn't do that for NoOpSentryExecutorService. See

sentry-java/sentry/src/main/java/io/sentry/Sentry.java

Lines 220 to 226 in e96a1b7

	// If the executorService passed in the init is the same that was previously closed, we have to
	// set a new one
	final ISentryExecutorService sentryExecutorService = options.getExecutorService();
	// If the passed executor service was previously called we set a new one
	if (sentryExecutorService.isClosed()) {
	options.setExecutorService(new SentryExecutorService());
	}

[adinauer]

@tjerkw we've opened #2747 to fix this by using daemon threads that no longer block shutdown.

[tjerkw]

Thanks for the quick response!

On Tue, 30 May 2023 at 13:33 Alexander Dinauer ***@***.***> wrote: Closed #2744 <#2744> as completed via #2747 <#2747>. — Reply to this email directly, view it on GitHub <#2744 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGH5MO42DFJAT5WIMLWOYTXIXLHZANCNFSM6AAAAAAYTB4VHU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- -- Tjerk Wolterink