-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing TempSensorBreadcrumbsIntegration from default integrations #2395
Comments
In a first version, let's provide a flag to disable the integration. Also add a section to the trouble shooting guide. |
@romtsn Why use a TYPE_AMBIENT_TEMPERATURE? |
@Sky24n I don't know, but my guess would be, developers might want to know if ambient temperature was high, which can explain high battery temperature as well. But I'll defer this to @marandaneto as he was the one implementing it |
https://developer.android.com/reference/android/hardware/Sensor#TYPE_TEMPERATURE
|
Why introduce the function of obtaining temperature? TempSensorBreadcrumbsIntegration |
Maybe the solution here is going with https://developer.android.com/reference/android/os/BatteryManager#EXTRA_TEMPERATURE @Sky24n feel free to submit a PR adding a flag as suggested by #2395 (comment) |
We already use Lines 529 to 539 in db18794
|
Description
We had a few reports about some Chinese stores flagging this integration as violating their policies, and therefore not allowing the apps to the stores.
TempSensorBreadcrumbsIntegration
#2355We could consider removing it from default integrations if the impact is high, or we could introduce a flag which specifically disables this integration (at the moment it sits behind
enableSystemBreadcrumbs
flag, which either disabled or enables all integrations related to system events)The text was updated successfully, but these errors were encountered: