Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging 'Stack peek was null when {method}' is misleading for some Hub calls. #1221

Closed
marandaneto opened this issue Feb 2, 2021 · 0 comments · Fixed by #1222
Closed

Logging 'Stack peek was null when {method}' is misleading for some Hub calls. #1221

marandaneto opened this issue Feb 2, 2021 · 0 comments · Fixed by #1222
Assignees
@maciejwalkowiak

Comments

@marandaneto
Copy link
Contributor

#1127 introduced changes on how to deal with the Scope stack but logging is off in a few cases.

eg:
setFingerprint
setUser
clearBreadcrumbs

If the stack can't be null, should we just remove them?
@marandaneto marandaneto added the Type: Bug Something isn't working label Feb 2, 2021
maciejwalkowiak added a commit that referenced this issue Feb 2, 2021
@maciejwalkowiak
Fix: Remove misleading error logs
71afb9d 
Fixes #1221
@maciejwalkowiak maciejwalkowiak mentioned this issue Feb 2, 2021
Merged
4 tasks
maciejwalkowiak added a commit that referenced this issue Feb 4, 2021
@maciejwalkowiak
Fix: Remove misleading error logs (#1222)
1431c5e 
Fixes #1221
@stephanie-anderson stephanie-anderson removed the Type: Bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maciejwalkowiak maciejwalkowiak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Remove misleading error logs getsentry/sentry-java
3 participants
@maciejwalkowiak @marandaneto @stephanie-anderson