Fix: Window.FEATURE_NO_TITLE does not work when using activity traces (…

…#1769)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+* Fix: Window.FEATURE_NO_TITLE does not work when using activity traces (#1769)
 * Fix: unregister UncaughtExceptionHandler on close (#1770)
 
 ## 5.2.3

sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java

@@ -227,7 +227,6 @@ private void finishTransaction(final @Nullable ITransaction transaction) {
   @Override
   public synchronized void onActivityCreated(
       final @NonNull Activity activity, final @Nullable Bundle savedInstanceState) {
-    activityFramesTracker.addActivity(activity);
     setColdStart(savedInstanceState);
     addBreadcrumb(activity, "created");
     startTracing(activity);
@@ -237,6 +236,13 @@ public synchronized void onActivityCreated(
 
   @Override
   public synchronized void onActivityStarted(final @NonNull Activity activity) {
+    // The docs on the screen rendering performance tracing
+    // (https://firebase.google.com/docs/perf-mon/screen-traces?platform=android#definition),
+    // state that the tracing starts for every Activity class when the app calls .onActivityStarted.
+    // Adding an Activity in onActivityCreated leads to Window.FEATURE_NO_TITLE not
+    // working. Moving this to onActivityStarted fixes the problem.
+    activityFramesTracker.addActivity(activity);
+
     addBreadcrumb(activity, "started");
   }
 

sentry-android-core/src/test/java/io/sentry/android/core/ActivityLifecycleIntegrationTest.kt

@@ -273,7 +273,7 @@ class ActivityLifecycleIntegrationTest {
         sut.register(fixture.hub, fixture.options)
 
         val activity = mock<Activity>()
-        sut.onActivityCreated(activity, fixture.bundle)
+        sut.onActivityStarted(activity)
 
         verify(fixture.activityFramesTracker).addActivity(eq(activity))
     }