Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: export map and sideEffects #464

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Fix: export map and sideEffects #464

merged 3 commits into from
Apr 11, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 11, 2022

Fixes #462

AbhiPrasad
AbhiPrasad approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about this when they posted the issue! Good to keep in mind :)

@timfish
Copy link
Collaborator Author

timfish commented Apr 11, 2022

It looks like many bundlers are just very loose with following the spec otherwise this would have been reported a lot earlier!

@timfish timfish merged commit d035052 into getsentry:master Apr 11, 2022
@timfish timfish deleted the fix/exports branch April 13, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken exports map
2 participants
@timfish @AbhiPrasad