-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map iOS Native BeforeSend & OnCrashedLastEvent to SentryOptions.Native #3958
base: main
Are you sure you want to change the base?
Conversation
….com/getsentry/sentry-dotnet into 2102-ios_beforesend_oncrashedlastrun
@jamescrosswell @bruno-garcia Native exceptions obviously teardown the MAUI apps. I can't unit test this properly due to needing to shutdown the app. Thoughts? Any internal mechanism I can call in native to have it "pretend" an issue occurred previously and force run BeforeSend/CrashedLastRun |
Over at https://github.com/getsentry/sentry-unity/ we're covering this via smoketests which to me seems more reliable to guarantee native-crash capture.
|
…nCrashedLastRun only available to IOS/MacCatalyst for now
I think the |
Can't really fake/mock the native layer though. This is smoke tested in the iOS sample app. |
…ue to SentryEnvelopeItem being deserialized instead of SentryEvent
…stead of trying to remap the entire object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good.
I think we might be able to refactor the code dealing with the OnBeforeSend event into a BeforeSendWrapper, like what was done for Android. That would make it easier/possible to write unit tests for all of that logic (and prevent regressions in the future).
This reverts commit bf4d33d.
Resolves #2102