Fix hash string case #2094
Merged
Fix hash string case #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - I reported the error I got with the case mismatch here: Appears to affect iOS only. |
bruno-garcia
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2050 I refactored some code to consolidate the
ToHexStringinternal extension method, and made it return the string in lower-case.However, the existing
GetHashStringmethod was using upper case previously. Switching to lower case created a problem (observed on iOS) where the caching transport failed to create its directory because another directory cased differently already existed.This PR adds an option for the casing. The default is lower-case, except for
GetHashStringwhere the default is upper-case to preserve previous behavior.#skip-changelog because #2050 where the bug was introduced has not yet been released.