Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): Add ANR docs around root cause analysis #7180

Merged
merged 11 commits into from
Jun 16, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 15, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Add ANR docs around new feature that analyzes the ANR stacktrace and gives hints to the users on how to resolve them.

@romtsn romtsn requested a review from a team as a code owner June 15, 2023 15:25
@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs 🛑 Canceled (Inspect) Jun 16, 2023 9:34am

@romtsn romtsn requested review from lizokm and shanamatthews June 15, 2023 15:26
kahest
kahest previously requested changes Jun 15, 2023
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good stuff 🚀
I left some changes to not use the "we" form when talking about Sentry alone (see guidelines)

src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
@romtsn
Copy link
Member Author

romtsn commented Jun 15, 2023

This is really good stuff 🚀 I left some changes to not use the "we" form when talking about Sentry alone (see guidelines)

I was hesitant exactly on this points, didn't know we have guidlines, that makes sense 👍

romtsn and others added 4 commits June 15, 2023 22:00
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I just have a few small tweaks.

src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
romtsn and others added 4 commits June 16, 2023 11:21
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@romtsn romtsn dismissed kahest’s stale review June 16, 2023 11:33

No more new feedback

@romtsn romtsn merged commit c892ec1 into master Jun 16, 2023
@romtsn romtsn deleted the rz/feat/anr-product-docs branch June 16, 2023 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants