Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): Add docs for new ANR implementation #6973

Merged
merged 10 commits into from
May 19, 2023
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 17, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Adds docs explaining differences between old and new ANR implementation.

@romtsn romtsn requested review from markushi and stefanosiano May 17, 2023 10:16
@romtsn romtsn requested a review from a team as a code owner May 17, 2023 10:16
@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 10:44am

@romtsn romtsn mentioned this pull request May 17, 2023
13 tasks
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my first readthrough I was unsure about when each version of the implementation would be used, so I made some suggestions to make it more obvious to readers.

Feel free to decline or re-edit if I got anything incorrect here!

src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
src/platforms/android/configuration/app-not-respond.mdx Outdated Show resolved Hide resolved
romtsn and others added 3 commits May 19, 2023 12:12
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@romtsn
Copy link
Member Author

romtsn commented May 19, 2023

thanks @shanamatthews all of the comments make sense, I addressed them 👍

@romtsn romtsn merged commit bde17b2 into master May 19, 2023
@romtsn romtsn deleted the rz/feat/anr-v2 branch May 19, 2023 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants