Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(apple): Rename APM tracking feature flags to tracing #5859

Merged
merged 2 commits into from
Jan 12, 2023
Merged

ref(apple): Rename APM tracking feature flags to tracing #5859

merged 2 commits into from
Jan 12, 2023

Conversation

kevinrenskers
Copy link
Contributor

@kevinrenskers kevinrenskers commented Nov 28, 2022 •
edited
Loading

Rename APM tracking feature flags to tracing
- Rename SentryOptions.enableAutoPerformanceTracking to enableAutoPerformanceTracing
- Rename SentryOptions.enableUIViewControllerTracking to enableUIViewControllerTracing
- Rename SentryOptions.enablePreWarmedAppStartTracking to enablePreWarmedAppStartTracing
- Rename SentryOptions.enableFileIOTracking to enableFileIOTracing
- Rename SentryOptions.enableCoreDataTracking to enableCoreDataTracing

See getsentry/sentry-cocoa#2450. This will be released with 8.0.0 of sentry-cocoa.

@kevinrenskers kevinrenskers requested a review from a team as a code owner November 28, 2022 17:28
@kevinrenskers kevinrenskers mentioned this pull request Nov 28, 2022
Closed
@vercel
Copy link

vercel bot commented Nov 28, 2022

@kevinrenskers is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@imatwawana imatwawana self-requested a review November 29, 2022 15:21
philipphofmann
philipphofmann approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kevinrenskers. We can only merge this after releasing Cocoa 8.0.0 GA.

@vercel
Copy link

vercel bot commented Dec 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 9:03PM (UTC)

@philipphofmann philipphofmann added this to the Apple 8.0.0 milestone Dec 12, 2022
@bruno-garcia
Copy link
Member

@kevinrenskers can't merge this, so if it's approved by @imatwawana and @philipphofmann one of us has to merge 👌

@imatwawana
Copy link
Contributor

@kevinrenskers can't merge this, so if it's approved by @imatwawana and @philipphofmann one of us has to merge 👌

Is Cocoa 8.0.0 in GA?

@kevinrenskers
Copy link
Contributor Author

No, not yet

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@philipphofmann philipphofmann enabled auto-merge (squash) January 12, 2023 10:02
@philipphofmann philipphofmann merged commit 94f9542 into getsentry:master Jan 12, 2023
@philipphofmann philipphofmann mentioned this pull request Jan 12, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@imatwawana imatwawana imatwawana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Apple 8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinrenskers @bruno-garcia @imatwawana @philipphofmann