-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android apollo3 integration #5289
Conversation
…a to include the new callback. align old code example and leave as alternative
…hScope and scope callback parameter of capture methods
…move with-scope section from android
@lbloder is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some style and wording edits. Some of the ones I made in the Android file should be replicated in the Java file.
src/platforms/java/common/performance/instrumentation/apollo3.mdx
Outdated
Show resolved
Hide resolved
src/platforms/java/common/performance/instrumentation/apollo3.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
|
||
ApolloClient apollo = ApolloBuilderExtensionsKt.sentryTracing(new ApolloClient.Builder()) | ||
.serverUrl("https://your-api-host/") | ||
.sentryTracing() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this redundant? It isn't included in the example further down under ## Modify or Drop Spans
|
||
ApolloClient apollo = ApolloBuilderExtensionsKt.sentryTracing(new ApolloClient.Builder()) | ||
.serverUrl("https://your-api-host/") | ||
.sentryTracing() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, some minor changes I'd like to see. Approving now to not have you blocked here whilie I'm gone. Please fix before merging.
@adinauer contractors don't have permission to merge docs, so it's up to us to do it 👌 |
Docs for getsentry/sentry-java#2109