Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note and alert guidance to contributor docs #3989

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

imatwawana
Copy link
Contributor

Adds guidance for the use of notes and alerts

@vercel
Copy link

vercel bot commented Aug 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/8H9VphmVacmZDLUTgqxBPqEzL2vH
✅ Preview: https://sentry-docs-git-update-add-note-guidance-to-contributor-docs.sentry.dev

@imatwawana imatwawana requested a review from PeloWriter August 5, 2021 22:58
Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - added bolding to highlight the different types.

src/docs/contributing/pages/components.mdx Outdated Show resolved Hide resolved
src/docs/contributing/pages/components.mdx Outdated Show resolved Hide resolved
src/docs/contributing/pages/components.mdx Outdated Show resolved Hide resolved
src/docs/contributing/pages/components.mdx Outdated Show resolved Hide resolved
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
@imatwawana imatwawana enabled auto-merge (squash) August 6, 2021 21:09
@imatwawana imatwawana merged commit ecc2735 into master Aug 6, 2021
@imatwawana imatwawana deleted the update/add-note-guidance-to-contributor-docs branch August 6, 2021 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants