Fix missing OS context for iOS events #958
Conversation
| if (key == SentryOperatingSystem.type && | ||
| currentValue is SentryOperatingSystem && | ||
| value is SentryOperatingSystem) { | ||
| final osMap = {...value.toJson(), ...currentValue.toJson()}; | ||
| final os = SentryOperatingSystem.fromJson(osMap); | ||
| eventContexts[key] = os; |
There was a problem hiding this comment.
It's a quick workaround for now, the whole process of merging contexts from the Native and Dart layer should be done differently.
There was a problem hiding this comment.
#942
Flutter sets the os.theme by default, so when merging the contexts, it does not take the os from the iOS layer since we don't merge field per field recursively, but rather if the key exists or not.
There was a problem hiding this comment.
Ahh, I see. Yeah, that's a stupid behavior.
Codecov Report
@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 89.52% 89.52%
=======================================
Files 105 105
Lines 3292 3292
=======================================
Hits 2947 2947
Misses 345 345 Continue to review full report at Codecov.
|
📜 Description
Fix missing OS context for iOS events
💡 Motivation and Context
Fix #942
💚 How did you test it?
📝 Checklist
🔮 Next steps
getsentry/team-mobile#11