-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add http response to event #934
Conversation
Codecov Report
@@ Coverage Diff @@
## main #934 +/- ##
==========================================
- Coverage 89.81% 89.52% -0.30%
==========================================
Files 104 105 +1
Lines 3212 3292 +80
==========================================
+ Hits 2885 2947 +62
- Misses 327 345 +18
Continue to review full report at Codecov.
|
@ueman Tests unless you are ok with this being accidentally reverted :P Said once a wise man. |
Yeeees, I just wanted to get some early feedback :D Also cc @kuhnroyal, I think you're probably interested in this, too. |
Hope I can find some time tomorrow to check it out. |
Looks good to me, ran this and have a nice new context in Sentry :) |
@ueman thanks for doing this. |
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Thanks @ueman as always. |
📜 Description
This PR adds the http response to an event.
See https://sentry.io/organizations/sentry-sdks/issues/3405926130/events/eaa5a7d9bd284b64ab3acd5238c61038/?project=5428562 for an example event.
Depends on #933
💡 Motivation and Context
Partially addresses #624.
There's also some more context in #933 and kuhnroyal#1 (comment).
Also see getsentry/develop#401 for the initial idea.
💚 How did you test it?
new tests
📝 Checklist
🔮 Next steps